ci: setup Java and adb in runner health check (WPB-21881)#4568
ci: setup Java and adb in runner health check (WPB-21881)#4568
Conversation
emmaoke-w
requested review from
CinnamonNinja,
MohamadJaara and
jschumacher-wire
and removed request for
CinnamonNinja
|
|
||
| curl -L -o platform-tools.zip https://dl.google.com/android/repository/platform-tools-latest-linux.zip | ||
| unzip -q platform-tools.zip | ||
|
|
There was a problem hiding this comment.
maybe we can add a step to clear the zip file after extracting
| rm platform-tools.zip |
| # Add adb to PATH for the rest of this workflow | ||
| echo "$HOME/platform-tools/platform-tools" >> "$GITHUB_PATH" |
There was a problem hiding this comment.
i am not sure about this working for the rest of the workflow i would exoect it to look like
export PATH="$HOME/platform-tools/platform-tools:$PATH"
but not 100% sure about it
There was a problem hiding this comment.
or you can just leave it as it is and check the adb version in th next step
|
@emmaoke-w looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
@emmaoke-w looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
@emmaoke-w looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
|
2 participants
https://wearezeta.atlassian.net/browse/WPB-21881
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.